Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rectified github workflow of this project #1524

Merged
merged 2 commits into from
Feb 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 30 additions & 20 deletions .github/workflows/master_dev_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,6 @@ jobs:
with:
java-version: 17

- name: PMD Check[Core]
run: ./gradlew core:pmd

- name: Upload PMD Report[Core]
uses: actions/[email protected]
if: failure()
with:
name: PMD Report[Core]
path: core/build/reports/

- uses: actions/checkout@v4
- name: PMD Check[MifosPay]
run: ./gradlew mifospay:pmd
Expand All @@ -111,6 +101,21 @@ jobs:
name: PMD Report[MifosPay]
path: mifospay/build/reports/

- name: Static Analysis[Core:Datastore]
run: ./gradlew core:datastore:pmd

- name: Static Analysis[Core:Data]
run: ./gradlew core:data:pmd

- name: Static Analysis[Core:DesignSystem]
run: ./gradlew core:designsystem:pmd

- name: Static Analysis[Core:Common]
run: ./gradlew core:common:pmd

- name: Static Analysis[Feature:Auth]
run: ./gradlew feature:auth:pmd

checkstyle:
name: Checkstyle
runs-on: ubuntu-latest
Expand All @@ -123,16 +128,6 @@ jobs:
with:
java-version: 17

- name: Checkstyle[Core]
run: ./gradlew core:checkstyle

- name: Upload Checkstyle Report[Core]
uses: actions/[email protected]
if: failure()
with:
name: Checkstyle Report[Core]
path: core/build/reports/

- uses: actions/checkout@v2
- name: Checkstyle[MifosPay]
run: ./gradlew mifospay:checkstyle
Expand All @@ -143,3 +138,18 @@ jobs:
with:
name: Checkstyle Report[MifosPay]
path: mifospay/build/reports/

- name: Static Analysis[Core:Datastore]
run: ./gradlew core:datastore:checkstyle

- name: Static Analysis[Core:Data]
run: ./gradlew core:data:checkstyle

- name: Static Analysis[Core:DesignSystem]
run: ./gradlew core:designsystem:checkstyle

- name: Static Analysis[Core:Common]
run: ./gradlew core:common:checkstyle

- name: Static Analysis[Feature:Auth]
run: ./gradlew feature:auth:checkstyle
2 changes: 2 additions & 0 deletions core/common/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ plugins {
alias(libs.plugins.mifospay.android.hilt)
}

apply(from = "${project.rootDir}/config/quality/quality.gradle")

android {
namespace = "org.mifos.mobilewallet.mifospay.common"
}
Expand Down
2 changes: 1 addition & 1 deletion core/data/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {
id("kotlinx-serialization")
}

//apply(from = "../config/quality/quality.gradle")
apply(from = "${project.rootDir}/config/quality/quality.gradle")

group = "com.github.ankurs287"

Expand Down
2 changes: 2 additions & 0 deletions core/datastore/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ plugins {
alias(libs.plugins.mifospay.android.hilt)
}

apply(from = "${project.rootDir}/config/quality/quality.gradle")

android {
namespace = "org.mifos.mobilewallet.datastore"
defaultConfig {
Expand Down
2 changes: 2 additions & 0 deletions core/designsystem/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ plugins {
alias(libs.plugins.mifospay.android.library.compose)
}

apply(from = "${project.rootDir}/config/quality/quality.gradle")

android {
defaultConfig {
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
Expand Down
2 changes: 2 additions & 0 deletions core/ui/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ android {
}
}

apply(from = "${project.rootDir}/config/quality/quality.gradle")

dependencies {

implementation(libs.androidx.core.ktx)
Expand Down
2 changes: 2 additions & 0 deletions feature/auth/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ android {
namespace = "org.mifos.mobilewallet.mifospay.feature.auth"
}

apply(from = "${project.rootDir}/config/quality/quality.gradle")

dependencies {
implementation(projects.core.data)

Expand Down
Loading