Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement theme selection for the project #49

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

HekmatullahAmin
Copy link
Contributor

@HekmatullahAmin HekmatullahAmin commented Mar 12, 2025

KMPPT-18

PR Summary:

  • Implemented Theme Selection feature.
  • Used expect getPlatform to determine if the device is Android. If so, a Green Android theme is available.
  • Leveraged supportsDynamicTheming to ensure dynamic theming is only available on Android 12+, as other platforms do not support dynamic themes.
  • Clicking "Change Theme" on Android allows users to:
    • Select between Default and Android themes.
    • If Default is chosen, users can enable/disable Dynamic Colors.
    • Toggle between Dark and Light Mode for all states.
  • On iOS, Web, and Desktop, users can only toggle between Light and Dark Mode.
  • Created a ThemeCard component, which opens the Theme Selection Dialog upon clicking.

Android

android.mov

IOS

iphone.mov

Desktop

Desktop.mov

Web

Web.mov

@HekmatullahAmin
Copy link
Contributor Author

@niyajali I implemented storage for theme, and language in core/datastore instead of sample. if you had time review it and let me know if you want to do any changes

@HekmatullahAmin HekmatullahAmin changed the title refactor(core:datastore): Implement real settings storage in core/datastore for theme and language feat: Implement theme selection for the project Mar 14, 2025
@niyajali niyajali merged commit 458c833 into openMF:dev Mar 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants