feat: Implement theme selection for the project #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niyajali I implemented storage for theme, and language in core/datastore instead of sample. if you had time review it and let me know if you want to do any changes |
niyajali
requested changes
Mar 13, 2025
feature/settings/src/commonMain/kotlin/org/mifos/feature/settings/SettingsScreen.kt
Outdated
Show resolved
Hide resolved
…astore for theme and language # Conflicts: # cmp-android/prodRelease-badging.txt
HekmatullahAmin
force-pushed
the
KMPPT-18
branch
from
8e935e6 to
1700f77
Compare
HekmatullahAmin
changed the title
niyajali
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KMPPT-18
PR Summary:
expect getPlatformto determine if the device is Android. If so, a Green Android theme is available.supportsDynamicThemingto ensure dynamic theming is only available on Android 12+, as other platforms do not support dynamic themes.Android
android.mov
IOS
iphone.mov
Desktop
Desktop.mov
Web
Web.mov