-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Configure iOS project to connect cmp-shared module #48
Conversation
3c8ad42
to
a8df7f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if you're able to build the iOS application then enable the workflow here..
build_ios: false # <-- Change to 'false' if you don't want to build iOS |
@@ -321,7 +321,7 @@ | |||
CODE_SIGN_IDENTITY = "Apple Development"; | |||
CODE_SIGN_STYLE = Automatic; | |||
DEVELOPMENT_ASSET_PATHS = "\"iosApp/Preview Content\""; | |||
DEVELOPMENT_TEAM = "${TEAM_ID}"; | |||
DEVELOPMENT_TEAM = L432S2FZP5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure, but previously, we were able to pass the team ID from another config file. I haven’t tried it yet, but I think we didn’t pass the team ID before, so the IDE used the variable. Now that you’ve provided the team ID, it’s directly applying the value instead of the variable. Could you look into this?
Yes, I just checked—we can pass the value from the following config file, and it will use the variable instead of hardcoded values for the team ID:
cmp-ios/Configuration/Config.xcconfig
@HekmatullahAmin Install fastlane and Ruby 3.5, then run the fastlane command to check if you can build the iOS application locally if you have a teamID. Previously, we didn’t have the teamID and were unable to test the fastlane configuration. Let me know the results. Refer to the Fastlane documentation: https://docs.fastlane.tools/. Instructions on how to run fastlane tasks can be found in the |
a8df7f0
to
bf56760
Compare
@niyajali my ruby version is videoScreen.Recording.2025-03-11.at.22.mp4screenshots:![]() ![]() ![]() |
@HekmatullahAmin run the fastlane jobs like |
@niyajali below is the result after running |
5cd2bf0
to
9beca9a
Compare
@therajanmaurya , @niyajali if it looks good then kindly merge it |
KMPPT-1