fix(feature:path-tracking): fix location permission handling and correct package name #2437
+23
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biplab1
changed the title
|
Note: I am not actively working on this PR at the moment. I have pushed the work done so far in case someone else wants to pick it up and continue from here. Feel free to close this PR once someone picks up the ticket. |
biplab1
changed the title
biplab1
force-pushed
the
MIFOSAC-495-path-tracking-fix
branch
from
c72f14c to
5a5d086
Compare
|
@niyajali This PR can be limited to the commits made and in a separate PR someone can fix the path tracking flows. Let me know how you would like me to proceed. |
biplab1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#495
Summary of changes:
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.