fix: Update server config not working #2435
Conversation
| @@ -119,6 +119,7 @@ class UpdateServerConfigViewModel( | |||
| ).any { it.value != null } | |||
|
|
|||
| if (!hasAnyError) { | |||
| prefManager.logOut() | |||
There was a problem hiding this comment.
are u sure to clean everything from userpreference in this operation?
There was a problem hiding this comment.
Calling prefManager.logOut() removes all saved values from persistent storage — this includes:
UserData, UserInfo, ServerConfig, AppTheme etc.
I believe you restart the app cause u updated the url or whatever, but does it mean the user should also lose his other states like selected app theme. I don't think it would be ideal for doing one operation also done in back sth that user didn't ask for. ask @niyajali about it.
There was a problem hiding this comment.
logout should not clear appThemes, I am not sure why its there. Maybe whoever did the UserPreferenceRepository took reference from mobile wallet since we don't have apptheme in there.
thanks for pointing it out @HekmatullahAmin
| @@ -38,10 +39,16 @@ val NetworkModule = module { | |||
| } | |||
| } | |||
|
|
|||
| single<String>(named("baseUrl")) { | |||
| val preferencesRepository = get<UserPreferencesRepository>() | |||
There was a problem hiding this comment.
move the named("baseUrl") in Qualifier.kt file and here directly call like it is done for MifosClient
| @@ -142,7 +133,7 @@ class UserPreferencesDataSource( | |||
|
|
|||
| suspend fun clearInfo() { | |||
| withContext(dispatcher) { | |||
| settings.clear() | |||
| settings.putAuth(User()) | |||
There was a problem hiding this comment.
Where does this method defined, and just clear the AUTh_USER and other related keys and keep the app specific configured as it is while logging out
There was a problem hiding this comment.
@niyajali clearInfo() is used while logging out and before updating server config.
I tried replacing it with this block of code, but it doesn't work correctly
suspend fun clearInfo() {
withContext(dispatcher) {
settings.remove(AUTH_USER)
}
}
so I had to use settings.putAuth(User())
Fixes - https://mifosforge.jira.com/browse/MIFOSAC-494