feat: settings migrate to cmp #2366
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kapmaurya Please change the branch to kmp-impl. |
biplab1
reviewed
Apr 28, 2025
core/database/src/androidMain/kotlin/com/mifos/room/MifosDatabase.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+20
to
+24
| // implementation(projects.core.datastore) | ||
| // implementation(projects.core.designsystem) | ||
| // implementation(projects.core.domain) | ||
| // implementation(projects.core.common) | ||
| // implementation(projects.core.ui) |
There was a problem hiding this comment.
These modules should be added to commonMain dependencies
Comment on lines
+547
to
+548
| androidx-ui-android = { group = "androidx.compose.ui", name = "ui-android", version.ref = "uiAndroid" } | ||
| material3-android = { group = "androidx.compose.material3", name = "material3-android", version.ref = "material3AndroidVersion" } |
There was a problem hiding this comment.
I don't think you need to add these separately, as these libraries are already present in libs.versions.toml
itsPronay
reviewed
Apr 28, 2025
feature/settings/build.gradle.kts
Outdated
Comment on lines
46
to
49
| implementation(libs.androidx.ui.android) | ||
| implementation(libs.material3.android) | ||
| } |
itsPronay
reviewed
Apr 28, 2025
Comment on lines
+184
to
+185
| uiAndroid = "1.8.0" | ||
| material3AndroidVersion = "1.3.2" |
There was a problem hiding this comment.
Remove them as well. already present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - [Jira-#Issue_Number](https://mifosforge.jira.com/browse/MIFOSAC-429)
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.