Feature:auth to cmp #2360
Open
Feature:auth to cmp #2360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
revanthkumarJ
suggested changes
Apr 11, 2025
| add("commonMainImplementation", project(":core:testing")) | ||
| add("commonMainImplementation", project(":core:data")) | ||
| // add("commonMainImplementation", project(":core:testing")) | ||
| // add("commonMainImplementation", project(":core:data")) |
There was a problem hiding this comment.
Remove the testing one instead of commenting
| @@ -141,7 +142,7 @@ internal fun LoginScreen( | |||
| modifier = modifier | |||
| .fillMaxSize() | |||
| .padding(16.dp), | |||
| containerColor = Color.White, | |||
| containerColor = White, | |||
| snackbarHost = { SnackbarHost(snackbarHostState) }, | |||
There was a problem hiding this comment.
I think we have to remove all explicitly defined colours like how we didit in mifos mobile
| error = usernameError.value?.let { it1 -> stringResource(it1) }, | ||
| trailingIcon = { | ||
| if (usernameError.value != null) { | ||
| Icon(imageVector = Icons.Filled.Error, contentDescription = null) | ||
| Icon(imageVector = MifosIcons.Error, contentDescription = null) | ||
| } |
There was a problem hiding this comment.
for content description give any valid string instead of null
| // modifier: Modifier, | ||
| // containerColor: Color, | ||
| // snackbarHost: () -> SnackbarHost, | ||
| // bottomBar: () -> Unit, |
| _loginUiState.value = | ||
| LoginUiState.ShowError(R.string.feature_auth_error_login_failed) | ||
| LoginUiState.ShowError(Res.string.feature_auth_error_login_failed) | ||
| Log.e("@@@", "login: ${result.message}") | ||
| } |
There was a problem hiding this comment.
you have removed import android.util.Log but didn't used Logger like that didn't it showing any error at Log?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#MIFOSAC-414
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.