Skip to content

1247 Replace Uniquenes validation for xml_id in ModelSolution and Test #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

kkoehn
Copy link
Contributor

@kkoehn kkoehn commented Feb 5, 2025

fixes #1247

@kkoehn kkoehn self-assigned this Feb 5, 2025
@kkoehn kkoehn linked an issue Feb 5, 2025 that may be closed by this pull request
@kkoehn kkoehn force-pushed the 1247-broken-xml_id-uniqueness-validation-for-tests branch from 7f13bb1 to 9714a2b Compare February 5, 2025 22:42
@kkoehn kkoehn requested a review from Dome-GER February 5, 2025 22:46
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.81%. Comparing base (5a9d6d3) to head (9714a2b).
Report is 265 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
+ Coverage   94.79%   94.81%   +0.01%     
==========================================
  Files         133      133              
  Lines        3345     3353       +8     
==========================================
+ Hits         3171     3179       +8     
  Misses        174      174              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dome-GER Dome-GER removed their request for review April 3, 2025 16:49
@kkoehn kkoehn requested a review from arkirchner May 28, 2025 19:19
Copy link

@arkirchner arkirchner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kkoehn kkoehn merged commit 16cc803 into main Jul 7, 2025
10 checks passed
@kkoehn kkoehn deleted the 1247-broken-xml_id-uniqueness-validation-for-tests branch July 7, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken XML_ID uniqueness validation for tests
2 participants