Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(all) add initial readmes for components and root #2

Merged
merged 5 commits into from
Jan 6, 2022

Conversation

michaelwarren1106
Copy link
Collaborator

@michaelwarren1106 michaelwarren1106 commented Dec 30, 2021

Items still needed:

  • Decide on usage example for FormControlMixin
  • Usage examples for utils
  • Codepen demo?

@calebdwilliams calebdwilliams added the documentation Improvements or additions to documentation label Jan 4, 2022
Copy link
Collaborator

@calebdwilliams calebdwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial feedback

@calebdwilliams
Copy link
Collaborator

As for a CodePen demo, that will probably make more sense once we have an initial version published so we can pull any code in from a CDN like Skypack and show how to use it. I do have a few demos I could put out there, but it's weird with all the source in there.

@michaelwarren1106 michaelwarren1106 marked this pull request as ready for review January 5, 2022 02:06
Copy link
Collaborator

@calebdwilliams calebdwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes …

Copy link
Collaborator

@calebdwilliams calebdwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change.

import { customElement, query, property } from 'lit/decorators.js'
import { live } from 'lit/directives/live.js';

import { FormControlMixin } from '@open-wc/form-participation';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be from @open-wc/form-control the way the project is currently structured.

Copy link
Collaborator

@calebdwilliams calebdwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@calebdwilliams calebdwilliams removed the request for review from Westbrook January 6, 2022 15:57
@calebdwilliams calebdwilliams merged commit d77c19c into main Jan 6, 2022
@michaelwarren1106 michaelwarren1106 deleted the documentation branch January 18, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants