-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(all) add initial readmes for components and root #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial feedback
As for a CodePen demo, that will probably make more sense once we have an initial version published so we can pull any code in from a CDN like Skypack and show how to use it. I do have a few demos I could put out there, but it's weird with all the source in there. |
b7c086b
to
5c6709b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes …
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change.
packages/form-control/README.md
Outdated
import { customElement, query, property } from 'lit/decorators.js' | ||
import { live } from 'lit/directives/live.js'; | ||
|
||
import { FormControlMixin } from '@open-wc/form-participation'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be from @open-wc/form-control
the way the project is currently structured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Items still needed: