Remove spec_unstable_logs_enabled feature -copilot try1 #3029

[cijothomas]

Fixes #3020

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.1%. Comparing base (1f0d9a9) to head (24b8453).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...telemetry-sdk/src/logs/concurrent_log_processor.rs	0.0%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #3031     +/-   ##
=======================================
- Coverage   81.1%   81.1%   -0.1%     
=======================================
  Files        126     126             
  Lines      24954   24949      -5     
=======================================
- Hits       20255   20250      -5     
  Misses      4699    4699             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR removes the spec_unstable_logs_enabled feature flag and unconditionally enables all log-related APIs across crates.

• Strips spec_unstable_logs_enabled from Cargo manifests and scripts
• Deletes #[cfg(feature = "spec_unstable_logs_enabled")] guards and imports
• Updates documentation and changelogs to reflect the breaking change

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
stress/Cargo.toml	Drop unstable logs feature from stress tests
scripts/lint.sh	Remove spec_unstable_logs_enabled from clippy checks
opentelemetry/src/logs/noop.rs	Unconditional event_enabled implementation
opentelemetry/src/logs/logger.rs	Always import and declare event_enabled
opentelemetry/src/lib.rs	Update docs to remove old feature flag
opentelemetry/Cargo.toml	Remove spec_unstable_logs_enabled from features
opentelemetry/CHANGELOG.md	Document removal of unstable logs feature
opentelemetry-stdout/Cargo.toml	Clean up logs feature dependencies
opentelemetry-sdk/src/logs/simple_log_processor.rs	Enable event_enabled always, remove cfg
opentelemetry-sdk/src/logs/logger.rs	Drop cfg import and enable guardless method
opentelemetry-sdk/src/logs/log_processor.rs	Remove #[cfg] and import for Severity
opentelemetry-sdk/src/logs/export.rs	Delete cfg guard from event_enabled
opentelemetry-sdk/src/logs/concurrent_log_processor.rs	Reorder methods and drop cfg on processor
opentelemetry-sdk/src/lib.rs	Update crate-level docs for logs features
opentelemetry-sdk/benches/log_enabled.rs	Adjust bench invocation comment
opentelemetry-sdk/Cargo.toml	Remove obsolete required-features from bench
opentelemetry-sdk/CHANGELOG.md	Note breaking change in SDK changelog
opentelemetry-appender-tracing/src/lib.rs	Update docs, remove old feature TODO
opentelemetry-appender-tracing/src/layer.rs	Drop cfg guard around event_enabled
opentelemetry-appender-tracing/Cargo.toml	Remove spec_unstable logs feature flag
opentelemetry-appender-tracing/CHANGELOG.md	Add removal note for unstable logs feature
opentelemetry-appender-log/src/lib.rs	Refactor enabled to always call event_enabled
opentelemetry-appender-log/Cargo.toml	Remove spec_unstable logs from features
opentelemetry-appender-log/CHANGELOG.md	Document unstable logs flag removal

Comments suppressed due to low confidence (3)

opentelemetry-appender-tracing/src/lib.rs:138

• There’s a stray empty doc comment (//!) right before the new removal notice. You can remove this line to avoid an empty documentation paragraph.

//!

opentelemetry-appender-log/src/lib.rs:93

• This is an empty doc comment that isn’t adding content. Removing it will clean up the Feature Flags section.

//!

opentelemetry-sdk/Cargo.toml:93

• The log_enabled bench no longer has any required-features defined, which may lead it to compile without the intended experimental_logs_concurrent_log_processor feature. Consider re-adding:

required-features = ["experimental_logs_concurrent_log_processor"]

harness = false

[utpilla]

That doesn't sound right. Only the event_enabled feature is being made always enabled. Users would still have to opt in for other optional features such as with-serde in this case.

[cijothomas]

Correct. Silly mistake by Copilot!