chore: remove redundant test logging #2943
Open
+1
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2943 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 126 126
Lines 24251 24251
=====================================
+ Hits 19732 19736 +4
+ Misses 4519 4515 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Had a quick skim for other instances and didn't find anything. Is it this simple? |
|
@scottgerring I compared the CI logs for integration test for this PR vs existing. The logs are not shown, for the CI runs in this PR, but it does show up in other PRs. What's your thought on removing our custom print-to-stdout, and instead rely on |
lalitb
reviewed
Apr 25, 2025
| #[allow(clippy::await_holding_lock)] | ||
| pub async fn start_collector_container() -> Result<()> { | ||
| init_tracing(); |
There was a problem hiding this comment.
If I recall correctly, this is not redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2841
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes