-
Notifications
You must be signed in to change notification settings - Fork 523
refactor: prioritize code-based config over env vars in OTLP exporter #2827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2827 +/- ##
=======================================
+ Coverage 79.7% 80.4% +0.7%
=======================================
Files 124 124
Lines 23297 23390 +93
=======================================
+ Hits 18578 18828 +250
+ Misses 4719 4562 -157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please modify the docs and changelog with more details so users will have easier time navigating this change.
Co-authored-by: Cijo Thomas <[email protected]>
@TommyCpp Could you also double check? I recall you suggested to add a |
Yep if that's the case then sounds fair to me |
Fixes #2818
Changes
timeout
field optional to properly handle code-based config prefer over env varsMerge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes