Skip to content

test: Improve OTLP Builder test #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Mar 17, 2025

Edit: Ignore is the best option now. See #2817 (comment)

@cijothomas cijothomas requested a review from a team as a code owner March 17, 2025 18:06
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.7%. Comparing base (1bce83f) to head (cbceb63).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-otlp/src/exporter/mod.rs 0.0% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2817     +/-   ##
=======================================
- Coverage   80.3%   79.7%   -0.6%     
=======================================
  Files        124     124             
  Lines      23333   23341      +8     
=======================================
- Hits       18754   18624    -130     
- Misses      4579    4717    +138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas closed this Mar 17, 2025
@cijothomas cijothomas reopened this Mar 17, 2025
@cijothomas cijothomas closed this Mar 17, 2025
@cijothomas cijothomas reopened this Mar 17, 2025
@cijothomas
Copy link
Member Author

This helped identify the root cause. The failures are due to some env variables being set by tests running in parallel. Given env variable are treated as high priority, this test is fragile now. The best option is to ignore them, until #2818 is resolved.

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lalitb lalitb merged commit a80dc0c into open-telemetry:main Mar 17, 2025
21 of 23 checks passed
@cijothomas cijothomas deleted the cijothomas/otlp-nit-tes branch March 17, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants