Skip to content

test: validate code based config is preferrred over env vars in trace BatchConfig #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2025

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Mar 15, 2025

Relates to #1225

Changes

  • this finishes up SDK. there is the trace Config but all the methods were deprecated so not worth validating them

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner March 15, 2025 15:47
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.2%. Comparing base (a442d62) to head (cc633fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2809   +/-   ##
=====================================
  Coverage   80.2%   80.2%           
=====================================
  Files        123     123           
  Lines      23346   23375   +29     
=====================================
+ Hits       18731   18762   +31     
+ Misses      4615    4613    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas merged commit e5f8a48 into open-telemetry:main Mar 16, 2025
23 checks passed
@cijothomas
Copy link
Member

Relates to #1225

Changes

  • this finishes up SDK. there is the trace Config but all the methods were deprecated so not worth validating them

Lets remove the deprecated methods too, since its been more than a release since they were deprecated?

@gruebel gruebel deleted the add-env-var-test branch March 16, 2025 06:44
cijothomas pushed a commit to cijothomas/opentelemetry-rust that referenced this pull request Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants