Skip to content

Remove unused Error enum #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

cijothomas
Copy link
Member

While reviewing #2381 I noted that there is a pub enum Error declared, that is not used anywhere in the codebase. I can't think of any reason why it exists, so removing it!

@scottgerring @lalitb Please see if you agree with this.

@cijothomas cijothomas requested a review from a team as a code owner January 24, 2025 00:35
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.8%. Comparing base (fdf4a63) to head (136d875).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2546   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        123     122    -1     
  Lines      23047   23044    -3     
=====================================
  Hits       17931   17931           
+ Misses      5116    5113    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to this, but better to have one more eye on it, in case we are missing any relevant use-case for it.

@cijothomas
Copy link
Member Author

I agree to this, but better to have one more eye on it, in case we are missing any relevant use-case for it.

A lot of this and other error types were originally used by global error handler, which is replaced with internal logging. We should be able to do lot more cleanups similar to this.

@cijothomas
Copy link
Member Author

I'll merge this to unblock progress and look for more. @scottgerring Good chance this'll affect your PR - I'll leave more comments there soon, and we can discuss together.

@cijothomas cijothomas merged commit 95fa209 into open-telemetry:main Jan 24, 2025
21 checks passed
@cijothomas cijothomas deleted the cijothomas/error-clean1 branch January 24, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants