chore: bring back BatchLogProcessorWithAsyncRuntime unit tests #2457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2457 +/- ##
=======================================
+ Coverage 76.1% 76.9% +0.7%
=======================================
Files 122 122
Lines 22066 22213 +147
=======================================
+ Hits 16793 17082 +289
+ Misses 5273 5131 -142 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Dec 19, 2024
opentelemetry-sdk/Cargo.toml
Outdated
| @@ -42,7 +42,7 @@ temp-env = { workspace = true } | |||
| pprof = { version = "0.13", features = ["flamegraph", "criterion"] } | |||
|
|
|||
| [features] | |||
| default = ["trace", "metrics", "logs", "internal-logs"] | |||
| default = ["trace", "metrics", "logs", "internal-logs", "experimental_logs_batch_log_processor_with_async_runtime"] | |||
There was a problem hiding this comment.
we shouldn't need this in the default, right?
There was a problem hiding this comment.
Oh i added this for local tests, will remove this.
cijothomas
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
These got removed as part of #2436. I think it's good to have them tested in CI to ensure nothing breaks.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes