Version pinning for tracing and tracing-core #2418
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2418 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 122 122
Lines 21708 21708
=====================================
Hits 17255 17255
Misses 4453 4453 ☔ View full report in Codecov by Sentry. |
| tracing-core = { version = "0.1", default-features = false } | ||
| # Using `tracing 0.1.40` because 0.1.39 (which is yanked) introduces the ability to set event names in macros, | ||
| # required for OpenTelemetry's internal logging macros. | ||
| tracing = { version = ">=0.1.40", default-features = false } |
There was a problem hiding this comment.
We need this particular version for internal logging only right? The appender can operate with "0.1" itself. Wondering if we should use separate ones for these, instead of forcing even appender to 0.1.40?
Not a blocker anyway as 0.1.40 is already an year old.
updated changelog. Regarding appender, I believe it can work at version 0.1. However things would be bit complex once we add otel internal logging in appender. Let me check if we can conditionally use the proper tracing version in appender as separate PR. |
Fixes: #2373
Changes
Pinning versions of tracing and tracing-core that are compatible with the version required to support name metadata in macros.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes