fix: make shutdown &self in span processor
#1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1836 +/- ##
=======================================
- Coverage 73.8% 73.8% -0.1%
=======================================
Files 122 122
Lines 19503 19503
=======================================
- Hits 14406 14404 -2
- Misses 5097 5099 +2 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
May 28, 2024
| @@ -26,6 +26,8 @@ | |||
| asynchronously, it should clone the log data to ensure it can be safely processed without | |||
| lifetime issues. | |||
|
|
|||
| - **Breaking** [1836](https://github.com/open-telemetry/opentelemetry-rust/pull/1836) `SpanProcessor::shutdown` now takes an immutable reference to self. Any reference can call shutdown on the processor. After the first call to `shutdown` the processor will not process any new spans. | |||
There was a problem hiding this comment.
I use Rewrap to keep comments wrapped!
cijothomas
approved these changes
May 28, 2024
|
This will allow us to add an explicit Shutdown method in TracerProvider, just like LoggerProvider? |
lalitb
approved these changes
May 28, 2024
ok got the answer here -#1801 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1801
Changes
SpanProcessor::shutdownnow takes a&selfinstead of&mut selfMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes