-
Notifications
You must be signed in to change notification settings - Fork 523
Adding PartialEq to AnyValue #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this.
There is the obligatory CLA signature 😓
Yes. Working on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1402 +/- ##
=====================================
Coverage 57.3% 57.3%
=====================================
Files 146 146
Lines 18184 18184
=====================================
Hits 10434 10434
Misses 7750 7750 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thanks for the fix.
c9db0db
to
6a803af
Compare
Changes got merged on #1415 . Closing this PR. |
Fixes #1401
Changes
opentelemetry::logs::AnyValue
to derive fromPartialEq
Merge requirement checklist
[ ] Unit tests added/updated (if applicable)[ ] AppropriateCHANGELOG.md
files updated for non-trivial, user-facing changes[ ] Changes in public API reviewed (if applicable)