Skip to content

Adding PartialEq to AnyValue #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

psandana
Copy link
Contributor

Fixes #1401

Changes

opentelemetry::logs::AnyValue to derive from PartialEq

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • [ ] Unit tests added/updated (if applicable)
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • [ ] Changes in public API reviewed (if applicable)

@psandana psandana requested a review from a team November 24, 2023 13:31
Copy link

linux-foundation-easycla bot commented Nov 24, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@hdost hdost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this.
There is the obligatory CLA signature 😓

@psandana
Copy link
Contributor Author

Thank you for adding this. There is the obligatory CLA signature 😓

Yes. Working on that.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd23ec2) 57.3% compared to head (6a803af) 57.3%.
Report is 1 commits behind head on main.

❗ Current head 6a803af differs from pull request most recent head b5c0dd4. Consider uploading reports for the commit b5c0dd4 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1402   +/-   ##
=====================================
  Coverage   57.3%   57.3%           
=====================================
  Files        146     146           
  Lines      18184   18184           
=====================================
  Hits       10434   10434           
  Misses      7750    7750           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for the fix.

@psandana psandana force-pushed the feature/1401-anyvalue-eq branch from c9db0db to 6a803af Compare November 30, 2023 16:33
@psandana
Copy link
Contributor Author

Changes got merged on #1415 .

Closing this PR.

@psandana psandana closed this Nov 30, 2023
@psandana psandana deleted the feature/1401-anyvalue-eq branch November 30, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: PartialEq support for AnyValue
5 participants