Skip to content

Test to validate identical instruments are merged #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cijothomas
Copy link
Member

Continuing from #1382, this adds one more test, validating a different aspect - instruments with matching identity must be merged to produce same metric stream.

I may add few more of similar tests (testing diff. aspects like view/callbacks etc.), and once all is done, we can identify common parts of these tests and move common code to helpers as opposed to duplicating a lot of code in each test. Also it'll be possible to test multiple things in single test.

@cijothomas cijothomas requested a review from a team November 21, 2023 00:02
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7848755) 57.2% compared to head (86346e0) 57.2%.

Files Patch % Lines
opentelemetry-sdk/src/metrics/mod.rs 97.8% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1385   +/-   ##
=====================================
  Coverage   57.2%   57.2%           
=====================================
  Files        146     146           
  Lines      18079   18126   +47     
=====================================
+ Hits       10343   10376   +33     
- Misses      7736    7750   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 3939ab5 into open-telemetry:main Nov 21, 2023
@cijothomas cijothomas deleted the cijothomas/metric-agg-merge-test branch November 21, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants