Skip to content

Fix eachdist dependency version matching#5237

Open
HasanTasdiq wants to merge 3 commits into
open-telemetry:mainfrom
HasanTasdiq:codex/fix-eachdist-dependency-match
Open

Fix eachdist dependency version matching#5237
HasanTasdiq wants to merge 3 commits into
open-telemetry:mainfrom
HasanTasdiq:codex/fix-eachdist-dependency-match

Conversation

@HasanTasdiq
Copy link
Copy Markdown
Contributor

@HasanTasdiq HasanTasdiq commented May 20, 2026

Fixes #5227

Summary

  • Tightened the dependency version replacement regex in scripts/eachdist.py.
  • Prevented package names that are prefixes of another package, such as opentelemetry-proto, from matching opentelemetry-proto-json.
  • Added the towncrier changelog fragment for this release-tooling fix.

Why

The release helper matched package name prefixes too broadly, so updating opentelemetry-proto could also rewrite dependencies for opentelemetry-proto-json.

Testing

  • Ran: targeted Python validation snippet for update_dependencies and update_patch_dependencies using temporary pyproject.toml fixtures - passed
  • Ran: python3 -m py_compile scripts/eachdist.py - passed

Notes

  • Full tox/precommit not run locally because uv and tox are not installed in this shell.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 20, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

@HasanTasdiq HasanTasdiq marked this pull request as ready for review May 20, 2026 22:52
@HasanTasdiq HasanTasdiq requested a review from a team as a code owner May 20, 2026 22:52
Copy link
Copy Markdown
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the regexp can be simplified by assuming there's only whitespace between package name and version.

@github-project-automation github-project-automation Bot moved this to Reviewed PRs that need fixes in Python PR digest May 21, 2026
Assisted-by: OpenAI Codex
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 5, 2026

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

@github-actions github-actions Bot added the Stale label Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Reviewed PRs that need fixes

Development

Successfully merging this pull request may close these issues.

scripts/eachdist.py dependency version search is not strict enough

2 participants