Update agent instructions#142
Open
lmolkova wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates contributor/agent-facing documentation to better standardize how GenAI instrumentation packages are added, tested (tox), and reviewed—especially around the newer util streaming helpers and shared test utilities—supporting upcoming migration work tracked in #141.
Changes:
- Documented how to wire a new
instrumentation/*package into the workspace,tox.ini, and progressive Pyright include/exclude. - Expanded guidance on tox usage (precommit, per-package envs, and conformance envs) and pre-PR checks.
- Added/updated instrumentation rules around util-based streaming wrappers and shared test harness usage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
AGENTS.md |
Adds workspace/tox/typecheck/test guidance plus streaming-wrapper and shared test-utility rules for instrumentations. |
.github/instructions/instrumentation.instructions.md |
Updates PR review rules for instrumentations, including streaming-wrapper expectations and test guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation to #141