Skip to content

Anthropic: emit gen_ai.provider.name instead of deprecated gen_ai.system #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AgentGymLeader wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Anthropic: emit gen_ai.provider.name instead of deprecated gen_ai.system #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions instrumentation/opentelemetry-instrumentation-genai-anthropic/.changelog/111.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Emit gen_ai.provider.name instead of deprecated gen_ai.system for Anthropic spans
4 changes: 3 additions & 1 deletion ...-genai-anthropic/src/opentelemetry/instrumentation/genai/anthropic/messages_extractors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,9 @@ def get_llm_request_attributes(
) -> dict[str, AttributeValue]:
attributes: dict[str, AttributeValue | None] = {
GenAIAttributes.GEN_AI_OPERATION_NAME: GenAIAttributes.GenAiOperationNameValues.CHAT.value,
GenAIAttributes.GEN_AI_SYSTEM: GenAIAttributes.GenAiSystemValues.ANTHROPIC.value, # pyright: ignore[reportDeprecated]
GenAIAttributes.GEN_AI_PROVIDER_NAME: (
GenAIAttributes.GenAiProviderNameValues.ANTHROPIC.value
),
Comment thread
AgentGymLeader marked this conversation as resolved.
GenAIAttributes.GEN_AI_REQUEST_MODEL: params.model,
GenAIAttributes.GEN_AI_REQUEST_MAX_TOKENS: params.max_tokens,
GenAIAttributes.GEN_AI_REQUEST_TEMPERATURE: params.temperature,
Expand Down
7 changes: 5 additions & 2 deletions instrumentation/opentelemetry-instrumentation-genai-anthropic/tests/test_async_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ async def test_async_messages_create_basic(
span = spans[0]
assert span.name == f"chat {model}"
assert span.attributes[GenAIAttributes.GEN_AI_OPERATION_NAME] == "chat"
assert span.attributes[GenAIAttributes.GEN_AI_SYSTEM] == "anthropic"
assert span.attributes[GenAIAttributes.GEN_AI_PROVIDER_NAME] == "anthropic"
assert span.attributes[GenAIAttributes.GEN_AI_REQUEST_MODEL] == model
assert span.attributes[GenAIAttributes.GEN_AI_RESPONSE_ID] == response.id
assert (
Expand Down Expand Up @@ -785,4 +785,7 @@ async def test_async_messages_create_event_only_no_content_in_span(
assert len(logs) == 1
log_record = logs[0].log_record
assert log_record.event_name == "gen_ai.client.inference.operation.details"
assert log_record.attributes[GenAIAttributes.GEN_AI_SYSTEM] == "anthropic"
assert (
log_record.attributes[GenAIAttributes.GEN_AI_PROVIDER_NAME]
== "anthropic"
)
8 changes: 2 additions & 6 deletions instrumentation/opentelemetry-instrumentation-genai-anthropic/tests/test_conformance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,12 @@
from .conformance.inference import InferenceScenario
from .conformance.tool_calling import ToolCallingScenario

_LEGACY_SYSTEM_SKIP = pytest.mark.skip(
reason="anthropic emits legacy gen_ai.system in experimental mode"
)


@pytest.mark.parametrize(
"scenario",
[
pytest.param(InferenceScenario(), marks=_LEGACY_SYSTEM_SKIP),
pytest.param(ToolCallingScenario(), marks=_LEGACY_SYSTEM_SKIP),
InferenceScenario(),
ToolCallingScenario(),
],
ids=lambda s: type(s).__name__,
)
Expand Down
4 changes: 2 additions & 2 deletions instrumentation/opentelemetry-instrumentation-genai-anthropic/tests/test_sync_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ def assert_span_attributes( # pylint: disable=too-many-arguments
== span.attributes[GenAIAttributes.GEN_AI_OPERATION_NAME]
)
assert (
GenAIAttributes.GenAiSystemValues.ANTHROPIC.value
== span.attributes[GenAIAttributes.GEN_AI_SYSTEM]
GenAIAttributes.GenAiProviderNameValues.ANTHROPIC.value
== span.attributes[GenAIAttributes.GEN_AI_PROVIDER_NAME]
)
Comment thread
lmolkova marked this conversation as resolved.
assert (
request_model == span.attributes[GenAIAttributes.GEN_AI_REQUEST_MODEL]
Expand Down