-
Notifications
You must be signed in to change notification settings - Fork 761
feat: Update opentelemetry-instrumentation-confluent-kafka to support confluent-kafka <=2.11.0 #3685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Update opentelemetry-instrumentation-confluent-kafka to support confluent-kafka <=2.11.0 #3685
Conversation
… confluent-kafka <=2.11.0
Hi @oxeye-dorkolog, would appreciate your CR here 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. After the fix, running tox -e generate
should be enough to bring everything in sync.
...instrumentation-confluent-kafka/src/opentelemetry/instrumentation/confluent_kafka/package.py
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-confluent-kafka/test-requirements.txt
Show resolved
Hide resolved
Ran it now, didn't seem to add any new changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see you've fixed all the comments, but changelog entry should be under # Unrelease section.
To fix ruff you may want to run tox -e ruff
locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see you've fixed all the comments, but changelog entry should be under # Unrelease section.
To fix ruff you may want to run tox -e ruff
locally
thanks @emdneto fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what's happening with asyncclick instrumentatio, but python-trio/asyncclick#37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI issue is solved now
Description
Update opentelemetry-instrumentation-confluent-kafka to support confluent-kafka <=2.11.0
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist: