Skip to content

feat: Update opentelemetry-instrumentation-confluent-kafka to support confluent-kafka <=2.11.0 #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

papigers
Copy link

@papigers papigers commented Aug 7, 2025

Description

Update opentelemetry-instrumentation-confluent-kafka to support confluent-kafka <=2.11.0

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Ran standard existing tests through tox

Does This PR Require a Core Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Documentation has been updated

@papigers papigers requested a review from a team as a code owner August 7, 2025 13:47
@papigers
Copy link
Author

Hi @oxeye-dorkolog, would appreciate your CR here 🙏

Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. After the fix, running tox -e generate should be enough to bring everything in sync.

@papigers
Copy link
Author

Thanks. After the fix, running tox -e generate should be enough to bring everything in sync.

Ran it now, didn't seem to add any new changes

Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see you've fixed all the comments, but changelog entry should be under # Unrelease section.
To fix ruff you may want to run tox -e ruff locally

Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see you've fixed all the comments, but changelog entry should be under # Unrelease section.
To fix ruff you may want to run tox -e ruff locally

@papigers
Copy link
Author

thanks @emdneto fixed now

Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's happening with asyncclick instrumentatio, but python-trio/asyncclick#37

Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI issue is solved now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants