-
Notifications
You must be signed in to change notification settings - Fork 572
support gatewayApi HTTPRoute creation by v1beta1 for otel CR #4510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
cc @frzifus |
|
@frzifus mind reviewing this one? |
|
Yes, set it on my list for tomorrow morning! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Horiodino ! I lefts some comments :)
Would be great if we could provide at least one e2e test to verify the httproute gets created and recognized by a gateway. Maybe we can deploy a standalone nginx or envoy for this.
bundle/community/manifests/opentelemetry-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Praful Khanduri <[email protected]>
Signed-off-by: Praful Khanduri <[email protected]>
Signed-off-by: Praful Khanduri <[email protected]>
|
cc @frzifus |
Description
Adds support for generating Gateway API
HTTPRouteresources from theOpenTelemetryCollectorv1beta1 spec. Includes the newhttpRouteconfiguration.Link to tracking Issue(s)
Testing
httpRoutehttpRouteenabledDocumentation
added API docs and changelog.
When enabled, the operator automatically generates an
HTTPRouteper HTTP port exposed by the collector’s configuration.