feat(api): add attributes argument to recordException API #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally introduced in open-telemetry#4071 but reverted in open-telemetry#4137 Co-authored-by: Marc Pichler <[email protected]>
brianphillips
force-pushed
the
attrs-in-record-exception
branch
from
bab99f3 to
f72fbb3
Compare
chancancode
reviewed
Jan 23, 2025
chancancode
reviewed
Jan 23, 2025
chancancode
reviewed
Jan 23, 2025
This clarifies the `recordException` method signature, cleans up the logic sequence and avoids an extra invocation of `sanitizeAttributes(...)`. See [this comment](https://github.com/open-telemetry/opentelemetry-js/pull/5333/files#r1926210496) for context Co-authored-by: Godfrey Chan <[email protected]>
brianphillips
force-pushed
the
attrs-in-record-exception
branch
from
e36accc to
66558e9
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This change was originally introduced in #4071 but subsequently reverted in #4137)
Co-authored-by: Marc Pichler [email protected]
Which problem is this PR solving?
Adds the optional attributes argument to the recordException API.
Fixes #4070 (again)
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
packages/opentelemetry-sdk-trace-base/test/common/Span.test.tsChecklist: