Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentelemetry-instrumentation): replace semver package with internal semantic versioning check implementation #5305

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat(opentelemetry-instrumentation): replace semver package with internal semantic versioning check implementation #5305

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
00b38ec
Replace `semver` package with internal semantic versioning check impl…
serkan-ozal Jan 8, 2025
f46808f
Update experimental/packages/opentelemetry-instrumentation/src/types.ts
serkan-ozal Jan 9, 2025
1b3b96d
Review comments
serkan-ozal Jan 9, 2025
ecabb39
Add changelog entry
serkan-ozal Jan 9, 2025
678edf6
Add license headers and info
serkan-ozal Jan 9, 2025
6070a9d
Merge branch 'main' into feat/get-rid-of-semver
serkan-ozal Jan 10, 2025
e33c0f3
Merge branch 'main' into feat/get-rid-of-semver
serkan-ozal Jan 10, 2025
235efeb
Merge branch 'main' into feat/get-rid-of-semver
serkan-ozal Jan 14, 2025
2b15a1e
Update experimental/packages/opentelemetry-instrumentation/src/semver.ts
serkan-ozal Jan 19, 2025
879d5e4
Update experimental/packages/opentelemetry-instrumentation/test/commo…
serkan-ozal Jan 19, 2025
a76f332
Update experimental/packages/opentelemetry-instrumentation/src/semver.ts
serkan-ozal Jan 19, 2025
a370a64
Update experimental/packages/opentelemetry-instrumentation/src/semver.ts
serkan-ozal Jan 19, 2025
73224f2
Update experimental/packages/opentelemetry-instrumentation/test/commo…
serkan-ozal Jan 19, 2025
7ec74f0
Add license for imported `node-semver` tests and import them as is
serkan-ozal Jan 19, 2025
b83e207
Update changelog entry
serkan-ozal Jan 19, 2025
9074cec
Update CHANGELOG.md
serkan-ozal Jan 22, 2025
cd24a25
Update experimental/packages/opentelemetry-instrumentation/test/commo…
serkan-ozal Jan 22, 2025
d39c5f1
Remove left over license header
serkan-ozal Jan 22, 2025
aa3f01f
Merge branch 'main' into feat/get-rid-of-semver
serkan-ozal Jan 22, 2025
49e4912
Merge remote-tracking branch 'origin/main' into feat/get-rid-of-semver
serkan-ozal Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ For semantic convention package changes, see the [semconv CHANGELOG](packages/se
* refactor(sdk-trace-base): remove `BasicTracerProvider._registeredSpanProcessors` private property. [#5134](https://github.com/open-telemetry/opentelemetry-js/pull/5134) @david-luna
* refactor(sdk-trace-base): rename `BasicTracerProvider.activeSpanProcessor` private property. [#5211](https://github.com/open-telemetry/opentelemetry-js/pull/5211) @david-luna
* chore(selenium-tests): remove internal selenium-tests/ package, it wasn't being used @trentm
* feat(opentelemetry-instrumentation): replace `semver` package with internal semantic versioning check implementation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could add the link to the PR here. COuld also give the reason for the removal in that sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trentm done


## 1.30.0

Expand Down
1 change: 0 additions & 1 deletion experimental/packages/opentelemetry-instrumentation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@
"@types/shimmer": "^1.2.0",
"import-in-the-middle": "^1.8.1",
"require-in-the-middle": "^7.1.1",
"semver": "^7.5.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should include semver as a development dependency to be used in tests. We could assert that our semver replacement functions output matches the semver package.

Copy link
Contributor Author

@serkan-ozal serkan-ozal Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have imported tests from semver package and test fixtures also include expected results (results of the actual semver package). That is the reason that why I had removed semver package dependency even from dev dependencies.

"shimmer": "^1.2.1"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import * as types from '../../types';
import * as path from 'path';
import { types as utilTypes } from 'util';
import { satisfies } from 'semver';
import { satisfies } from '../../semver';
import { wrap, unwrap, massWrap, massUnwrap } from 'shimmer';
import { InstrumentationAbstract } from '../../instrumentation';
import {
Expand Down
Loading
Loading