Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(propagator-aws-xray): support lineage in xray trace header #2679

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(propagator-aws-xray): support lineage in xray trace header #2679

wants to merge 4 commits into from

Conversation

ezhang6811
Copy link

@ezhang6811 ezhang6811 commented Jan 24, 2025 •
edited
Loading

Which problem is this PR solving?

  • Current XRay Propagator does not support Lineage attribute for Lambda invocations, which the other OpenTelemetry language SDK's do so using baggage. see this Java PR for similar solution.

Short description of the changes

  • Include Lambda lineage attribute in X-Ray trace header.
  • Changed getSpanContextFromHeader to getContextFromHeader in the extract() method, since we must return an updated context with a new baggage object if the lineage exists.

@ezhang6811 ezhang6811 requested a review from a team as a code owner January 24, 2025 23:12
@github-actions github-actions bot requested a review from jj22ee January 24, 2025 23:12
@ezhang6811 ezhang6811 changed the title feat(propagator-x feat(propagator-aws-xray): support lineage in xray trace header Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jj22ee jj22ee Awaiting requested review from jj22ee

At least 1 approving review is required to merge this pull request.

Assignees

@jj22ee jj22ee

Labels
pkg:propagator-aws-xray
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezhang6811 @jj22ee