Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-mongodb): Add requireParentSpan config option. #2658

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

onurtemizkan
Copy link
Contributor

Which problem is this PR solving?

Resolves: #1910

Short description of the changes

  • Adds requireParentSpan config option to the mongodb instrumentation

@onurtemizkan onurtemizkan requested a review from a team as a code owner January 17, 2025 00:21
@github-actions github-actions bot added pkg:instrumentation-mongodb pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 47.61905% with 11 lines in your changes missing coverage. Please review.

Project coverage is 90.96%. Comparing base (e57f3e4) to head (7cba82a).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...try-instrumentation-mongodb/src/instrumentation.ts 47.61% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2658      +/-   ##
==========================================
+ Coverage   90.79%   90.96%   +0.16%     
==========================================
  Files         169      172       +3     
  Lines        8061     8146      +85     
  Branches     1646     1647       +1     
==========================================
+ Hits         7319     7410      +91     
+ Misses        742      736       -6     
Files with missing lines Coverage Δ
...opentelemetry-instrumentation-mongodb/src/types.ts 100.00% <ø> (ø)
...try-instrumentation-mongodb/src/instrumentation.ts 48.93% <47.61%> (+0.97%) ⬆️

... and 8 files with indirect coverage changes

Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@david-luna
Copy link
Contributor

I'll sponsor this.

@david-luna david-luna added the has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions label Jan 21, 2025
@onurtemizkan onurtemizkan force-pushed the mongodb-requireParentSpan branch from 14b6fca to 89f7318 Compare January 23, 2025 13:12
@onurtemizkan onurtemizkan force-pushed the mongodb-requireParentSpan branch from 89f7318 to 7cba82a Compare January 23, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions pkg:instrumentation-mongodb pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mongodb instrumentation does not generate traces if it is executed outside of HTTP calls.
2 participants