-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(instrumentation-fastify): deprecate instrumentation in favor of @fastify/otel #2651
Open
pichlermarc
wants to merge
4
commits into
open-telemetry:main
Choose a base branch
from
dynatrace-oss-contrib:chore/deprecate-fastify
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
docs(instrumentation-fastify): deprecate instrumentation in favor of @fastify/otel #2651
pichlermarc
wants to merge
4
commits into
open-telemetry:main
from
dynatrace-oss-contrib:chore/deprecate-fastify
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
added
pkg:instrumentation-fastify
has:sponsor
This package or feature has a sponsor that has volunteered to review PRs and respond to questions
labels
Jan 16, 2025
github-actions
bot
added
the
pkg-status:unmaintained
This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
label
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2651 +/- ##
==========================================
+ Coverage 90.79% 90.96% +0.17%
==========================================
Files 169 172 +3
Lines 8061 8137 +76
Branches 1646 1649 +3
==========================================
+ Hits 7319 7402 +83
+ Misses 742 735 -7
|
pichlermarc
commented
Jan 23, 2025
trentm
approved these changes
Jan 25, 2025
|
||
If total installation size is not constrained, it is recommended to use the [`@opentelemetry/auto-instrumentations-node`](https://www.npmjs.com/package/@opentelemetry/auto-instrumentations-node) bundle with [@opentelemetry/sdk-node](`https://www.npmjs.com/package/@opentelemetry/sdk-node`) for the most seamless instrumentation experience. | ||
This module provides automatic instrumentation for the [`fastify`](https://www.fastify.io/) module, which may be loaded using the [`@opentelemetry/sdk-trace-node`](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-node) package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
This module provides automatic instrumentation for the [`fastify`](https://www.fastify.io/) module, which may be loaded using the [`@opentelemetry/sdk-trace-node`](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-node) package. | |
This module provides automatic instrumentation for the [`fastify`](https://www.fastify.dev/) module, which may be loaded using the [`@opentelemetry/sdk-trace-node`](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-node) package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
has:sponsor
This package or feature has a sponsor that has volunteered to review PRs and respond to questions
pkg:instrumentation-fastify
pkg-status:unmaintained
This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Ownership of the instrumentation is moving to https://github.com/fastify/otel. Fastify will provide and maintain an official instrumentation (
@fastify/otel
) going forward.See #2647
Short description of the changes
This PR deprecates
@opentelemetry/instrumentation-fastify
(once merged, I will follow up with deprecation on npm)