Metadata for the JAX-RS family #14669
Open
+564
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
commented
Sep 15, 2025
| - io.javalin:javalin:[5.0.0,) | ||
| jaxrs: | ||
| - name: jaxrs-1.0 | ||
| disabled_by_default: true |
There was a problem hiding this comment.
while technically this instrumentation is disabled by default in the sense that it requires otel.instrumentation.common.experimental.controller-telemetry.enabled, I want to use the disabled_by_default condition to only apply to instrumentation modules that set the actual module disabled with the standard enabled flag.
I have plans for a different way for us to identify instrumentations that aren't necessarily "disabled by default", but that are otherwise entirely gated by an experimental flag
laurit
reviewed
Sep 18, 2025
docs/instrumentation-list.yaml
Outdated
| - name: code.namespace | ||
| type: STRING | ||
| - name: jaxrs-2.0-cxf-3.2 | ||
| display_name: JAX-RS 2.x |
There was a problem hiding this comment.
should be cxf-... instead of jax-rs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13468 and #14128