otellogr: Fix nil context panic #6527
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6527 +/- ##
=======================================
- Coverage 68.7% 68.7% -0.1%
=======================================
Files 200 200
Lines 16872 16873 +1
=======================================
- Hits 11604 11602 -2
- Misses 4925 4927 +2
- Partials 343 344 +1
|
dmathieu
changed the title
Co-authored-by: Damien Mathieu <[email protected]>
# Conflicts: # CHANGELOG.md
- Remove `ctx` field and related context handling from `LogSink` struct - Simplify `Enabled` method to use `context.Background()` directly - Remove `WithContext` method and associated tests - Clean up test cases related to context handling
pellared
changed the title
I think this is the proper fix and we probably do not need anything more than this. |
…est struct for clarity
|
Ready for approval. |
| @@ -352,6 +352,40 @@ func TestLogSink(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // fix https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6509 | |||
| func TestLogSinkCtxInInfo(t *testing.T) { | |||
There was a problem hiding this comment.
Couldn't we add test cases to TestLogSink instead?
There was a problem hiding this comment.
Upon checking, the structure of TestLogSink is currently not suitable for my testing scenario. If adjustments are needed, more changes might be required.
There was a problem hiding this comment.
OK. Approving. I can look and try refactoring it tomorrow.
|
@scorpionknifes, PTAL as a codeowner |
| @@ -352,6 +352,40 @@ func TestLogSink(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // fix https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6509 | |||
| func TestLogSinkCtxInInfo(t *testing.T) { | |||
There was a problem hiding this comment.
OK. Approving. I can look and try refactoring it tomorrow.
Fixes #6509