Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Replace some fields with auto properties #6104

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

SimonCropp
Copy link
Contributor

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@SimonCropp SimonCropp requested a review from a team as a code owner January 26, 2025 23:58
@github-actions github-actions bot added pkg:OpenTelemetry.Exporter.Prometheus.HttpListener Issues related to OpenTelemetry.Exporter.Prometheus.HttpListener NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Jan 26, 2025
Copy link
Contributor

@TimothyMothra TimothyMothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch changed the title use some auto properties [repo] Replace some fields with auto properties Jan 27, 2025
@CodeBlanch CodeBlanch merged commit 89ea5c6 into open-telemetry:main Jan 27, 2025
44 checks passed
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (c44984e) to head (bb2844e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6104      +/-   ##
==========================================
- Coverage   86.40%   86.39%   -0.01%     
==========================================
  Files         257      257              
  Lines       11648    11640       -8     
==========================================
- Hits        10064    10056       -8     
  Misses       1584     1584              
Files with missing lines Coverage Δ
...etheus.HttpListener/Internal/PrometheusExporter.cs 100.00% <ø> (ø)
src/OpenTelemetry/Metrics/ExportModesAttribute.cs 100.00% <ø> (ø)
src/OpenTelemetry/ReadOnlyFilteredTagCollection.cs 100.00% <ø> (ø)

@SimonCropp SimonCropp deleted the use-some-auto-properties branch January 27, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.Prometheus.HttpListener Issues related to OpenTelemetry.Exporter.Prometheus.HttpListener NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants