move for to foreach #6103
Closed
move for to foreach #6103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg:OpenTelemetry.Api
CodeBlanch
reviewed
Jan 27, 2025
| @@ -68,9 +68,9 @@ public CompositeTextMapPropagator(IEnumerable<TextMapPropagator> propagators) | |||
| /// <inheritdoc/> | |||
| public override PropagationContext Extract<T>(PropagationContext context, T carrier, Func<T, string, IEnumerable<string>?> getter) | |||
| { | |||
| for (int i = 0; i < this.propagators.Count; i++) | |||
| foreach (var propagator in this.propagators) | |||
There was a problem hiding this comment.
The problem here is when you foreach it is a call to _thing_.GetEnumerator(). If thing is an interface like IEnumerable or IReadOnlyList then GetEnumerator() usually returns an IEnumerator. The implementation for the enumerator on the concrete type is usually a struct so converting it to IEnumerator causes a boxing allocation. Agree the foreach is more readable, but the fors are written specifically to cheat and avoid these allocations. Avoiding allocations is a great good than readability in this case IMO.
There was a problem hiding this comment.
fair enough. will close
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6103 +/- ##
==========================================
- Coverage 86.40% 86.28% -0.12%
==========================================
Files 257 257
Lines 11649 11506 -143
==========================================
- Hits 10065 9928 -137
+ Misses 1584 1578 -6
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
given the majority of loops in the repo are written as foreach. i figure converting the remaining for loops to foreach makes sense.
also IMO foreach loops improve code readability compared to for loops
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes