Skip to content

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Nov 14, 2025

Fixes #3725

Changes

Please provide a brief description of the changes here.

  • When a sampler returns Decision::DROP or Decision::RECORD_ONLY, clear the trace sample flag, per specs.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team as a code owner November 14, 2025 22:21
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.01%. Comparing base (6dcf647) to head (c7bac53).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3745      +/-   ##
==========================================
+ Coverage   90.01%   90.01%   +0.01%     
==========================================
  Files         225      225              
  Lines        7105     7106       +1     
==========================================
+ Hits         6395     6396       +1     
  Misses        710      710              
Files with missing lines Coverage Δ
api/include/opentelemetry/trace/trace_flags.h 100.00% <ø> (ø)
sdk/src/trace/tracer.cc 83.88% <100.00%> (+0.27%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Child spans inherit the parent’s TraceFlags::kIsSampled bit even when the active sampler returns Decision::DROP

1 participant