Bump log4j to 2.25.4#59
Closed
Sanikadze wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hi, @Sanikadze ! Thank you for your PR. This project is mostly in maintenance mode - no new features introduced here. Only backports from apache/cloudberry-pxf. Could you please create the same PR to apache/cloudberry-pxf? We will merge this into cloudberry-pxf firstly, and then merge this PR here. |
Contributor
|
Need some time to compare 'before' and 'after' dependency tries... |
Contributor
|
Cherry-picked from cloudberry-pxf to open-gpdb/pxf as b987ba1 Thank you for your contribution! |
Contributor
|
log4j upgrade works well in tests, however it breaks PXF when it is working with very old JDBC drivers. Currently our fleet have installations with JDBC drivers that bundles log4j 2.17.x. Reopenning this PR in order to be merge it when no old JDBC drivers left. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump log4j from 2.17.2 to 2.25.4. Closes CVE-2026-34480 (XmlLayout invalid XML output) and CVE-2026-34477 (SSL hostname verification bypass).
Changes
server/build.gradleext['log4j2.version'] = '2.25.4'so the version managed by the importedspring-boot-dependenciesBOM (which pins log4j-bom 2.17.2) is overridden. A bomProperty override does not reach the nested log4j-bom, hence the explicit ext property.log4j-spring-boot:2.17.2pin (and its junit excludes) withlog4j-spring-boot:2.25.4. The excludes were a workaround for junit leaking into compileClasspath in 2.17.2; this was fixed upstream in 2.19.0, so at 2.25.4 they are dead code (the old comment said to remove them on upgrade).server/pxf-service/build.gradleVerification
./gradlew :pxf-api:test :pxf-service:teston JDK 8 — BUILD SUCCESSFUL, 679 tests, 678 passed, 0 failed, 1 skipped.api/core/jul/spring-boot, with no junit leaked into the jar and commons-logging-1.1.3 present.StatusLoggerinit errors and no log4j config errors;