Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Flipt provider gem with basic implementation #51

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Add Flipt provider gem with basic implementation #51

wants to merge 4 commits into from

Conversation

falghi
Copy link

@falghi falghi commented Mar 29, 2025 •
edited
Loading

This PR

  • Adds a new gem project: Flipt provider
  • Adds basic implementation for feature flags evaluation

Some references:

  1. https://github.com/open-feature/js-sdk-contrib/blob/main/libs/providers/flipt/src/lib/flipt-provider.ts
  2. https://docs.flipt.io/reference/overview

Follow-up Tasks

  • Initial release of Flipt provider gem

How to test

  • Pull this gem locally and test if it works in a Ruby application
  • Tests are passed

Screenshot 2025-03-30 at 4 19 01

beeme1mr
beeme1mr approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start! Thanks for the PR.

@beeme1mr beeme1mr requested a review from markphelps April 8, 2025 13:26
@beeme1mr
Copy link
Member

beeme1mr commented Apr 8, 2025

@falghi please sign off your previous commits when you have a moment. It's a requirement from the CNCF.

falghi added 4 commits April 9, 2025 10:51
@falghi
feat: Add initial Flipt Provider
9818e1e 
Signed-off-by: Firdaus Al Ghifari <[email protected]>
@falghi
test: Add unit tests for Flipt Provider
9076504 
Signed-off-by: Firdaus Al Ghifari <[email protected]>
@falghi
ci: Add ci for flipt provider
6cef975 
Signed-off-by: Firdaus Al Ghifari <[email protected]>
@falghi
chores: Add flipt provider to code-workspace
503ce10 
Signed-off-by: Firdaus Al Ghifari <[email protected]>
@falghi falghi force-pushed the alghi/add-flipt-provider branch from 64289af to 503ce10 Compare April 9, 2025 01:54
@falghi
Copy link
Author

falghi commented Apr 9, 2025

@beeme1mr Done! Signed all my commits ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@markphelps markphelps Awaiting requested review from markphelps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@falghi @beeme1mr