-
Notifications
You must be signed in to change notification settings - Fork 44
chore(main): release web-sdk 1.7.0 #1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(main): release web-sdk 1.7.0 #1265
Conversation
Summary of ChangesHello @openfeaturebot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents an automated release of the OpenFeature Web SDK, incrementing its version to 1.7.0. The primary enhancement included in this release is the integration of the MultiProvider feature, which was previously housed in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automates the release of web-sdk
version 1.7.0
. The changes correctly update the version in .release-please-manifest.json
, packages/web/package.json
, and the release badge in packages/web/README.md
. The CHANGELOG.md
is also updated with the new version and the feature it contains: the migration of MultiProvider
.
The code for the MultiProvider
feature is not in the provided diffs, but I've reviewed the full files provided for context. I have some feedback that could be addressed in a follow-up pull request, as the relevant files are not part of this PR's diff:
- Documentation Mismatch in README: In
packages/web/README.md
, the code example forMulti-Provider
shows an import ofWebMultiProvider
. However, the actual class exported by the SDK isMultiProvider
. This could cause confusion for developers trying to use this new feature. - Redundant Error Logging: In
packages/web/src/provider/multi-provider/hook-executor.ts
, theerrorHooks
andfinallyHooks
methods contain logic that logs an error's stack trace twice if the error is an instance ofError
. This will create duplicate entries in the logs.
These points are mentioned here for your consideration as they fall outside the changed lines in this pull request. The release itself appears to be in order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the feedback from Gemini should be addressed prior to merging.
β¦ror logging (#1267) Addresses feedback from #1265 (Gemini bot review comments). ## Changes 1. **Fixed documentation mismatch**: Updated all code examples to use `MultiProvider` instead of incorrect `WebMultiProvider` class name - `packages/web/README.md` (4 occurrences) - `packages/web/src/provider/multi-provider/README.md` (4 occurrences) 2. **Removed duplicate error logging**: Fixed redundant stack trace logging in `hook-executor.ts` where errors were being logged twice in both `errorHooks` and `finallyHooks` methods <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> Signed-off-by: Jonathan Norris <[email protected]>
Signed-off-by: OpenFeature Bot <[email protected]>
be23f0f
to
3c8f509
Compare
β¦web-sdk Signed-off-by: Michael Beemer <[email protected]>
π€ Release is at https://github.com/open-feature/js-sdk/releases/tag/web-sdk-v1.7.0 π» |
π€ I have created a release beep boop
1.7.0 (2025-10-21)
β¨ New Features
π Bug Fixes
This PR was generated with Release Please. See documentation.