feat!: update otel hook to use new semconv #1372
Merged
+1,328
−314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas-reining
force-pushed
the
feat/otel-hook-update
branch
2 times, most recently
from
aced118 to
dbeac9b
Compare
|
I've merged the change in the JS repo but the changes haven't been released yet. |
beeme1mr
reviewed
Sep 29, 2025
lukas-reining
force-pushed
the
feat/otel-hook-update
branch
2 times, most recently
from
ff94516 to
821ae17
Compare
lukas-reining
changed the title
lukas-reining
force-pushed
the
feat/otel-hook-update
branch
4 times, most recently
from
d260a1d to
1894958
Compare
beeme1mr
reviewed
Sep 30, 2025
lukas-reining
commented
Sep 30, 2025
lukas-reining
commented
Sep 30, 2025
beeme1mr
reviewed
Oct 1, 2025
Sure, I will change the README and fix/add the tests now. |
lukas-reining
force-pushed
the
feat/otel-hook-update
branch
2 times, most recently
from
5219e96 to
f8cfca5
Compare
lukas-reining
commented
Oct 5, 2025
lukas-reining
commented
Oct 5, 2025
|
This is ready to review now. I finished the tests and upated the README. |
toddbaert
reviewed
Oct 8, 2025
toddbaert
reviewed
Oct 8, 2025
toddbaert
reviewed
Oct 8, 2025
toddbaert
approved these changes
Oct 8, 2025
toddbaert
reviewed
Oct 8, 2025
beeme1mr
reviewed
Oct 8, 2025
lukas-reining
force-pushed
the
feat/otel-hook-update
branch
5 times, most recently
from
a931b4d to
3260efc
Compare
Signed-off-by: Lukas Reining <[email protected]>
lukas-reining
force-pushed
the
feat/otel-hook-update
branch
2 times, most recently
from
8b9e095 to
c60a696
Compare
Signed-off-by: Lukas Reining <[email protected]>11 Signed-off-by: Lukas Reining <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>11 Signed-off-by: Lukas Reining <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>11 Signed-off-by: Lukas Reining <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>11 Signed-off-by: Lukas Reining <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>11 Signed-off-by: Lukas Reining <[email protected]>
beeme1mr
approved these changes
Oct 9, 2025
Signed-off-by: Lukas Reining <[email protected]>11 Signed-off-by: Lukas Reining <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Implements new SemConv for OTEL tracing hook.