-
Notifications
You must be signed in to change notification settings - Fork 59
feat(flagsmith): upgrade-provider-to-latest-flagsmith-client-version #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flagsmith): upgrade-provider-to-latest-flagsmith-client-version #1362
Conversation
7e8375f
to
95c5af3
Compare
… v2.10.2 (open-feature#1355) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: wadii <[email protected]>
…ature#1359) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: wadii <[email protected]>
Signed-off-by: wadii <[email protected]>
Signed-off-by: wadii <[email protected]>
Signed-off-by: wadii <[email protected]>
Signed-off-by: wadii <[email protected]>
604822d
to
fc3f68f
Compare
Bringing this one to your attention @thomaspoignant :) |
Hey @Zaimwa9 I am not sure why it was assigned to me (since I am not super knowledgeable of flagsmith). |
Hey @Zaimwa9, I updated the title to a feat because it will trigger a version bump and be included in the release notes. I'll wait for @matthewelwell or @dabeeeenster from Flagsmith to give the final approval. Thanks for the PR! |
@beeme1mr thanks for the review! I'm working at flagsmith as a disclaimer 😄. We will major the sdk soon (with no impact here) so I will delay this PR until we do if that's ok for you -and have the CI passing by then!- |
…into chore/feature-provider-flagsmith-sdk-upgrade
@beeme1mr , if that's ok, we will stick to this version for now as the major is delayed. So this one is ready to be merged. Thanks again for your help, I appreciate |
…pen-feature#1362) Signed-off-by: wadii <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: wadii <[email protected]>
This PR
This PR aims to upgrade the flagsmith provider in order to be compatible with latest versions of the flagsmith sdk (from
4.x.x
to9.x.x
).Main breaking change from those versions was the introduction of
evaluationContext
in the FS sdk and the use offlagsmithClient.setContext
to properly identify users and assign traits (also stores the environment ApiKey).This was not compatible with the
flagsmith-client-provider
which was switching identity using the deprecatedthis.identity
Related Issues
#1351 solved a similar bug. It feels cleaner to bump the version - which does include the fix. I can include the Readme updates and close the previous one?
Notes
Follow-up Tasks
Following-up on the discussion here
Refactoring in a more abstract way should come in a different scope 👍
How to test
BEGIN_COMMIT_OVERRIDE
feat(flagsmith): upgrade-provider-to-latest-flagsmith-client-version
Release-As: 0.2.0
END_COMMIT_OVERRIDE