Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bumped to java 11, altered CI to target java 11 #1393

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jarebudev
Copy link
Contributor

draft PR - have added it as wanted to verify my initial changes builds the CI first up before going further

This PR

Moves the sdk to java 11

Related Issues

Resolves #1371

Notes

draft at the moment

Follow-up Tasks

N/A

How to test

N/A

@jarebudev jarebudev requested a review from a team as a code owner March 26, 2025 21:59
@jarebudev jarebudev marked this pull request as draft March 26, 2025 22:03
@jarebudev jarebudev changed the title DRAFT - feat: bumped to java 11, altered CI to target java 11 feat: bumped to java 11, altered CI to target java 11 Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (e251819) to head (eb8fd3f).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1393      +/-   ##
============================================
+ Coverage     92.81%   93.25%   +0.44%     
- Complexity      469      471       +2     
============================================
  Files            43       43              
  Lines          1127     1127              
  Branches         91       91              
============================================
+ Hits           1046     1051       +5     
+ Misses           53       48       -5     
  Partials         28       28              
Flag Coverage Δ
unittests 93.25% <ø> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, the changes to the github action and pom look great, thank you. This is highly appreciated, but should we really change all the java code, it just adds unnecessary changes to the pull request. :)

@jarebudev
Copy link
Contributor Author

Hey, the changes to the github action and pom look great, thank you. This is highly appreciated, but should we really change all the java code, it just adds unnecessary changes to the pull request. :)

No worries, I can revert the last commit and leave the source unchanged if that's desired. Can always reapply JDK11 language refactoring afterwards in another PR.

@jarebudev jarebudev force-pushed the 1371_java11_refactor branch from 678e04e to 53fbb2c Compare April 7, 2025 20:33
Copy link

sonarqubecloud bot commented Apr 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Migrate to Java 11
2 participants