CPP Scene Refactor #290
Closed
CPP Scene Refactor #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the virtual overrides not to bother with pointer logic. This is the first step. The next step should be to consolidate every model type to scene output without a sub ResultBase. This can now be done gradually
Refactored quite a bit for the tiler since saliency maps are cv::Mats now.
Due to changes in the structure it was not possible to keep the same reference. This means that the python string output needs to be changed too slightly. This can be done without changing the python structure.
Test references not redone
The public scope reference output is different now Until python output will match the cpp we will split the reference output.
github-actions
bot
added
tests
|
The generic output pattern will not be flexible enough for the future. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big refactor of the output for C++.
Generalize the output to one
Sceneobject. This allows us to reduce a lot of the pointer logic for the model base.Scene contains all output. For example: Classification and Detection models will output boxes into the scene. Segmentation models will output masks which can then be used to generate polygons or rotated rectangles.
This is a rather huge refactor so I'm listing some todos until we're ready:
There is a lot more work to be done. But in the spirit of trying to keep PRs small lets start with this.