Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue causing coco dataset parsing to fail in stream mode when the annotations json contains additional, unused keys. To achieve this, the PR adds a non-strict mode to the
JsonPageMapper
in the rust API, and uses it in theCocoPageMapper
to allow and ignore unknown keys. With these changes, the behaviour of COCO parsing is now similar between stream mode and non-stream mode.Changes:
JsonPageMapper
CocoPageMapper
, while disabling it for other page mapper classes.skip_serde_json_value
function torust/src/utils.rs
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.