Skip to content

Conversation

@ClaraStefania
Copy link

No description provided.

@razvand razvand self-requested a review January 26, 2025 13:14
@razvand razvand self-assigned this Jan 26, 2025
@razvand razvand added the enhancement New feature or request label Jan 26, 2025
Copy link

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a full message as part of your commits. State in the full message the rationale for that commit, i.e. what issue does it solve, why is the commit required. The Update README commit message is obviously to generic to be a useful commit message.

Also, I would place the stdin_bof.c and stdin_bof files in a directory (maybe called samples/). Add a Makefile used to build the stdin_bof.c file into the stdin_bof binary executable.

@ClaraStefania ClaraStefania force-pushed the clara-vuln-det-fixes branch from da61e4c to a586ec2 Compare May 8, 2025 20:18
@razvand razvand self-requested a review August 29, 2025 13:59
Copy link

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use your correct name as author and as part of the Signed-off-by message, i.e. Clara Diaconescu <[email protected]>.

You'll have to go through the history of commits and update them.

You should update your Git configuration:

git config --global user.name="Clara Diaconescu"
git config --global user.email="[email protected]"

Alternatively, you can set up the corresponding environment variables:

export GIT_AUTHOR_NAME="Clara Diaconescu"
export GIT_AUTHOR_EMAIL="[email protected]"
export GIT_COMMITTER_NAME="Clara Diaconescu"
export GIT_COMMITTER_EMAIL="[email protected]"

Then, to update the author for a commit, use:

git commit --amend --reset-author

Update the commit messages. Add a full commit description for each commit (a commit description is the block paragraph after the commit title): use proper sentences, follow the best best practices on creating commits and commit messages.

Copy link

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Python instead of python in commit messages.

Improve installation and setup instructions in
README.md by adding detailed steps and clarifying
the process.

Signed-off-by: Clara Diaconescu <[email protected]>
Set Python requirement to 3.10 to have the
same version as the other modules. Add 'commons'
as a local dependency and 'requests' package.

Signed-off-by: Clara Diaconescu <[email protected]>
Add stdin_bof.c source file and 32-bit
binary for testing standard input fuzzing.

Signed-off-by: Clara Diaconescu <[email protected]>
Update to use a more recent version.

Signed-off-by: Clara Diaconescu <[email protected]>
Fix a few typos.

Signed-off-by: Clara Diaconescu <[email protected]>
Move the stdin_bof.c example to a dedicated directory for
better organization. Add a Makefile to build the stdin_bof
example for 32-bit architecture.

Signed-off-by: Clara Diaconescu <[email protected]>
'console' is preferred for examples showing both commands and
terminal output.

Signed-off-by: Clara Diaconescu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants