-
Notifications
You must be signed in to change notification settings - Fork 1
Fixes to make the module work #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a full message as part of your commits. State in the full message the rationale for that commit, i.e. what issue does it solve, why is the commit required. The Update README commit message is obviously to generic to be a useful commit message.
Also, I would place the stdin_bof.c and stdin_bof files in a directory (maybe called samples/). Add a Makefile used to build the stdin_bof.c file into the stdin_bof binary executable.
da61e4c to
a586ec2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use your correct name as author and as part of the Signed-off-by message, i.e. Clara Diaconescu <[email protected]>.
You'll have to go through the history of commits and update them.
You should update your Git configuration:
git config --global user.name="Clara Diaconescu"
git config --global user.email="[email protected]"Alternatively, you can set up the corresponding environment variables:
export GIT_AUTHOR_NAME="Clara Diaconescu"
export GIT_AUTHOR_EMAIL="[email protected]"
export GIT_COMMITTER_NAME="Clara Diaconescu"
export GIT_COMMITTER_EMAIL="[email protected]"Then, to update the author for a commit, use:
git commit --amend --reset-authorUpdate the commit messages. Add a full commit description for each commit (a commit description is the block paragraph after the commit title): use proper sentences, follow the best best practices on creating commits and commit messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Python instead of python in commit messages.
Improve installation and setup instructions in README.md by adding detailed steps and clarifying the process. Signed-off-by: Clara Diaconescu <[email protected]>
Set Python requirement to 3.10 to have the same version as the other modules. Add 'commons' as a local dependency and 'requests' package. Signed-off-by: Clara Diaconescu <[email protected]>
Add stdin_bof.c source file and 32-bit binary for testing standard input fuzzing. Signed-off-by: Clara Diaconescu <[email protected]>
Update to use a more recent version. Signed-off-by: Clara Diaconescu <[email protected]>
Fix a few typos. Signed-off-by: Clara Diaconescu <[email protected]>
Move the stdin_bof.c example to a dedicated directory for better organization. Add a Makefile to build the stdin_bof example for 32-bit architecture. Signed-off-by: Clara Diaconescu <[email protected]>
'console' is preferred for examples showing both commands and terminal output. Signed-off-by: Clara Diaconescu <[email protected]>
a586ec2 to
bbf1cfc
Compare
No description provided.