Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add postfix relay support #542

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: add postfix relay support #542

wants to merge 6 commits into from

Conversation

RobHooper
Copy link
Contributor

This PR adds relay support to Postfix. We need this on portland-dev in order to send administrative email as they are being blocked by the ISP.

@jpmckinney , pillar.smtp is already configured on Credere, but I cannot see where it is in use in Salt?
I re-used smtp because it configures the same service this adds to Postfix.
However, if this clashes other parts of the code, we could rename the values in this PR to pillar.postfix.relay.

To Do:

  • Create SMTP credentials and add to pillar private (docs)
  • Merge and deploy to portland-dev

@RobHooper RobHooper requested a review from jpmckinney February 6, 2025 11:52
@RobHooper RobHooper self-assigned this Feb 6, 2025
@jpmckinney
Copy link
Member

jpmckinney commented Feb 6, 2025

pillar.smtp is already configured on Credere, but I cannot see where it is in use in Salt?

Ah, it's not used, indeed - we configure it again in the same file as AWS_REGION, AWS_ACCESS_KEY, AWS_CLIENT_SECRET. The credentials were the first thing I added, before the app had any environment variables.

I've removed it now.

@jpmckinney
Copy link
Member

Create SMTP credentials and add to pillar private (docs)

I think we can reuse the credentials in smtp.sls?

pillar/portland_dev.sls Show resolved Hide resolved
salt/core/mail.sls Show resolved Hide resolved
salt/core/mail.sls Outdated Show resolved Hide resolved
salt/core/mail.sls Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants