-
Notifications
You must be signed in to change notification settings - Fork 68
✨ add --bundle-version-overrides
flag; update default bundle to OCM v0.16.1
#488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add --bundle-version-overrides
flag; update default bundle to OCM v0.16.1
#488
Conversation
Signed-off-by: Tyler Gillson <[email protected]>
Signed-off-by: Tyler Gillson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR!
I'm okay with the changes, but just wondering is the original bundle-version
param only useful for setting latest
? Should we consolidate the new param and the existing one? Or we should just add the extra parameter like you've done?
/assign @qiujian16
Edit: renamed the flag to |
Signed-off-by: Tyler Gillson <[email protected]>
Signed-off-by: Tyler Gillson <[email protected]>
Signed-off-by: Tyler Gillson <[email protected]>
--bundle-version-overrides
flag; update default bundle to OCM v0.16.1
/approve |
/assign @dhaiducek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the update!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, qiujian16, TylerGillson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6385821
into
open-cluster-management-io:main
Summary
--bundle-version-overrides
flag for customizing the version bundle used byclusteradm