Skip to content

✨ add --bundle-version-overrides flag; update default bundle to OCM v0.16.1 #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TylerGillson
Copy link
Contributor

@TylerGillson TylerGillson commented May 26, 2025

Summary

  • Add --bundle-version-overrides flag for customizing the version bundle used by clusteradm
  • Update default bundle to install OCM v0.16.1

@openshift-ci openshift-ci bot requested review from dhaiducek and ycyaoxdu May 26, 2025 18:55
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

I'm okay with the changes, but just wondering is the original bundle-version param only useful for setting latest? Should we consolidate the new param and the existing one? Or we should just add the extra parameter like you've done?

/assign @qiujian16

@TylerGillson
Copy link
Contributor Author

TylerGillson commented May 27, 2025

One other thing is that, for all commands that also support --bundle-version, the new param doesn't appear next to it due to alphabetization. I'm open to switching the new flag to --bundle-version-file if that would be preferred...

Edit: renamed the flag to --bundle-version-overrides. Now it appears next to --bundle-version.

Signed-off-by: Tyler Gillson <[email protected]>
Signed-off-by: Tyler Gillson <[email protected]>
@TylerGillson TylerGillson requested a review from qiujian16 May 28, 2025 15:18
@TylerGillson TylerGillson changed the title ✨ flag to customize version bundle; update default bundle to OCM v0.16.1 ✨ add --bundle-version-overrides flag; update default bundle to OCM v0.16.1 May 28, 2025
@qiujian16
Copy link
Member

/approve

@mikeshng
Copy link
Member

/assign @dhaiducek

Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update!

@openshift-ci openshift-ci bot added the lgtm label May 29, 2025
Copy link

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, qiujian16, TylerGillson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6385821 into open-cluster-management-io:main May 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants