introduce multiple choices for activation criteria in ActivableFraction product; sanitize saturation vs. supersaturation naming and units across the codebase
#1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slayoo
changed the title
activable_fraction productactivable_fraction product; sanitize saturation vs. supersaturation naming across the codebase
slayoo
changed the title
activable_fraction product; sanitize saturation vs. supersaturation naming across the codebaseActivableFraction product; sanitize saturation vs. supersaturation naming across the codebase
…alculated for initial temperature; sanitizing nomenclature and API for saturation vs. supersaturation; adding _percent to identifiers containing 100-multiplied values
slayoo
force-pushed
the
activation_criteria_with_dan
branch
from
58104f0 to
f44a375
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1595 +/- ##
==========================================
+ Coverage 85.53% 85.57% +0.04%
==========================================
Files 396 397 +1
Lines 9601 9630 +29
==========================================
+ Hits 8212 8241 +29
Misses 1389 1389 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
slayoo
changed the title
ActivableFraction product; sanitize saturation vs. supersaturation naming across the codebaseActivableFraction product; sanitize saturation vs. supersaturation naming and units across the codebase
|
thank you @AgnieszkaZaba |
|
Yes, I see that after updating plotter it works with with percent unit and without. I hope I didn't miss any plots ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.