-
Notifications
You must be signed in to change notification settings - Fork 47
Homogeneous freezing (as a new option in Freezing
dynamic, disabled by default + new physics formulae for hom. nucl. rate); new example: Spichtinger_et_al_2023
#1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…oment with RH_ice. Deleted singular case for hom. freezing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1488 +/- ##
==========================================
+ Coverage 85.53% 85.66% +0.12%
==========================================
Files 396 403 +7
Lines 9601 9771 +170
==========================================
+ Hits 8212 8370 +158
- Misses 1389 1401 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ting to existing S. et al. Fig 2 test, return NaN in Null class
…n room temp definition...)
Freezing
dynamic, disabled by default + new physics formulae for hom. nucl. rate); new example: Spichtinger_et_al_2023
@tluettm, trying to figure out why the windows
while the current
It is 1.5 minutes longer now, and seems the longer time is reproducible. |
@slayoo You can try to add it where you think it would help. For me its not clear where to introduce |
…g down unrelated tests
…freezing nucleation rate
… by default + new physics formulae for hom. nucl. rate); new example: `Spichtinger_et_al_2023` (open-atmos#1488) Co-authored-by: Sylwester Arabas <[email protected]>
… by default + new physics formulae for hom. nucl. rate); new example: `Spichtinger_et_al_2023` (open-atmos#1488) Co-authored-by: Sylwester Arabas <[email protected]>
Added homogeneous freezing routines as an optional freezing mode in the freezing dynamic