Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI tests for sample phoenix application #652

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fastjames
Copy link

In order to ensure the correctness of the example phoenix application, exercise it in the CI test suite.

In order to ensure the correctness of the example phoenix application,
exercise it in the CI test suite.
@fastjames
Copy link
Author

fastjames commented Feb 18, 2025

The test I added here should accomplish my original intent, by exposing the typespec mismatch (it does when I run mix dialyzer on the example app locally). However, it also finds a few other dialyzer errors too. I will see if I can knock those out as well in this PR (leaving them as separate commits in case they need to be split into multiple PRs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant