Skip to content

Conversation

@larshp
Copy link
Member

@larshp larshp commented Dec 8, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Performance test results:

Performance Before After Delta
CL_CONVERSION_EXIT_INPUT 798ms 790ms -8 🟢
CL_JSON_PARSING1 1386ms 1348ms -38 🟢
CL_UI2_DESERIALIZE1 366ms 377ms 11 🟢
CL_UI2_SERIALIZE1 158ms 167ms 9 🟢

Updated: 2025-12-08T15:54:34.973Z

SHA: df98baf

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the SQL result set handling by adding proper boolean type conversion and updates several @abaplint dependencies to newer versions.

  • Adds JavaScript kernel code to detect boolean values and convert them to ABAP convention ("X" for true, "" for false)
  • Updates @abaplint/cli, @abaplint/runtime, and @abaplint/transpiler-cli packages to newer versions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/adbc/cl_sql_result_set.clas.abap Adds boolean type detection and conversion logic in the next() method to properly handle boolean SQL result values
package.json Updates @abaplint dependencies to newer patch versions (cli: 2.114.6, runtime/transpiler-cli: 2.12.16)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@larshp
Copy link
Member Author

larshp commented Dec 8, 2025

currently down, https://httpbin.org/get

@larshp larshp marked this pull request as ready for review December 8, 2025 15:59
@larshp larshp merged commit 5c958ec into main Dec 8, 2025
8 of 10 checks passed
@larshp larshp deleted the hvam/sql0812 branch December 8, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants